feat: player improvements — gestures, haptics, queue, lyrics & back-handling#124
Open
Ericgacoki wants to merge 1 commit into
Open
feat: player improvements — gestures, haptics, queue, lyrics & back-handling#124Ericgacoki wants to merge 1 commit into
Ericgacoki wants to merge 1 commit into
Conversation
…andling Player screen: - Pager commits the track change on release (settledPage) instead of at the 50% point, fixing premature/unwanted track switches. - Seekbar seeks only on release; dragging no longer fires a flood of seek/API calls. - Drag the mini-player down to dismiss: clears the queue (player + VM cache) with a vibrant haptic and an Undo snackbar (hosted at the app Scaffold so it stays visible after dismiss). Axis-based, so it doesn't clash with the prev/next swipe (ref #68). - Expanding the mini-player no longer auto-starts a paused track (replaced the racy play()/pause() seed on session reconnect with a direct state seed). - Central soft haptic on committed actions (play/pause, next/prev, seek-release, shuffle, repeat, favorite). Queue sheet: - Tapping the pinned now-playing closes the queue (exact reverse of the Queue icon); the player stays expanded. - Reversing a downward drag to upward pulls the sheet back up instead of the tracks list capturing it. Lyrics: - Reduced the progress-bar (divider) height. - Long-press a lyric line to copy its text. Back navigation: - With the player expanded over another screen, device Back minimizes the player (closing the queue first if open) instead of navigating the screen behind — the BackHandler is now registered after the NavHost so it wins. Follow-up: - Migrate haptics off direct Vibrator calls to Compose's native HapticFeedback (#123).
Member
Author
|
Fixes #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch of player UX fixes and small features, verified on-device.
Player screen
settledPage) instead of at the 50% point — fixes premature/unwanted track switches.Scaffoldso it stays visible after dismiss). Axis-based, so it doesn't clash with the prev/next swipe. (ref [Feature Request] Swipe on the mini player to close #68)play()/pause()seed on session reconnect with a direct state seed).Queue sheet
Lyrics
Back navigation
BackHandleris now registered after theNavHostso it wins.Follow-up
Vibratorcalls to Compose's nativeHapticFeedback. (Refactor: delegate haptics to Compose's HapticFeedback instead of direct Vibrator calls #123)